Updates sample cert and admin keystore #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
Bukhtawar,
bharath-techie,
Arpit-Bandejiya and
pranikum
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
Coverage ? 84.16%
Complexity ? 557
=======================================
Files ? 61
Lines ? 2046
Branches ? 146
=======================================
Hits ? 1722
Misses ? 226
Partials ? 98 ☔ View full report in Codecov by Sentry. |
|
should be merged post opensearch-project/security#4061 is merged |
mch2
approved these changes
Mar 25, 2024
|
Hello reviewers, This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0. Looks like it would need backport to 2.x and 2.13? Thanks! |
Rishikesh1159
approved these changes
Mar 25, 2024
|
multi-node test workflow is currently broken on main unrelated to this. Attempting to resolve that first |
|
Haven't been able to resolve the bwc issue quickly. Will go ahead with this to unblock testing of 2.13 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93)
mch2
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
mch2
pushed a commit
that referenced
this pull request
Mar 26, 2024
----- Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
mch2
pushed a commit
to mch2/asynchronous-search
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
mch2
added
backport 2.x
This comment was marked as outdated.
This comment was marked as outdated.
mch2
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 5a39c93) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit 5a39c93) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit 5a39c93) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downstream change coming from security plugin: opensearch-project/security#4061
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.